On Tue, Nov 3, 2009 at 1:48 PM, Artem Bityutskiy <[email protected]> wrote: > On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote: >> Looping Linux-omap mailing list. >> >> >> From: Vimal Singh <[email protected]> >> Date: Fri, 30 Oct 2009 11:31:34 +0530 >> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c' >> >> Fixing below warning in compilation: >> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref': >> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of >> 'omap_nand_dma_transfer' discards qualifiers from pointer target type >> >> Signed-off-by: Vimal Singh <[email protected]> >> --- >> drivers/mtd/nand/omap2.c | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) > > [dedek...@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal > ERROR: patch seems to be corrupt (line wrapped?) > #94: FILE: drivers/mtd/nand/omap2.c:500: > mtd_info *mtd, u_char *buf, int len) > > total: 1 errors, 0 warnings, 16 lines checked > > vimal has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > [dedek...@eru l2-mtd-2.6.git]$ vim vimal > [dedek...@eru l2-mtd-2.6.git]$ git am vimal > Applying: Fixing compilation warning for 'nand/omap2.c' > fatal: corrupt patch at line 10 > Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c' > When you have resolved this problem run "git am --resolved". > If you would prefer to skip this patch, instead run "git am --skip". > To restore the original branch and stop patching run "git am --abort". > [dedek...@eru l2-mtd-2.6.git]$ >
Grr... its again mailer's issue. Fixed this in below patch: -vimal >From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001 From: Vimal Singh <[email protected]> Date: Fri, 30 Oct 2009 11:31:34 +0530 Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c' Fixing below warning in compilation: drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref': drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of 'omap_nand_dma_transfer' discards qualifiers from pointer target type Signed-off-by: Vimal Singh <[email protected]> --- drivers/mtd/nand/omap2.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 090ab87..92573d5 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct mtd_info *mtd, u_char static void omap_write_buf_dma_pref(struct mtd_info *mtd, const u_char *buf, int len) { + u_char *p = (u_char *)buf; + if (len <= mtd->oobsize) - omap_write_buf_pref(mtd, buf, len); + omap_write_buf_pref(mtd, p, len); else /* start transfer in DMA mode */ - omap_nand_dma_transfer(mtd, buf, len, 0x1); + omap_nand_dma_transfer(mtd, p, len, 0x1); } /** -- 1.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
