* Roel Kluin <[email protected]> [091101 05:07]: > The index `cs' is signed, test whether it is negative before > we release gpmc_cs_mem[cs]. > > Signed-off-by: Roel Kluin <[email protected]> > --- > Found by code analysis, is it required?
Looks like a valid check to me. Acked-by: Tony Lindgren <[email protected]> > > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c > index 1587682..c892a54 100644 > --- a/arch/arm/mach-omap2/gpmc.c > +++ b/arch/arm/mach-omap2/gpmc.c > @@ -378,7 +378,7 @@ EXPORT_SYMBOL(gpmc_cs_request); > void gpmc_cs_free(int cs) > { > spin_lock(&gpmc_mem_lock); > - if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { > + if (cs >= GPMC_CS_NUM || cs < 0 || !gpmc_cs_reserved(cs)) { > printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); > BUG(); > spin_unlock(&gpmc_mem_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
