Hi,
> > > If you do stick with this approach you probably want to use snprintf()
> > > and make supply be 6 bytes rather than 5 bytes long.
> > >
> > > > + for (i = 0 ; i < OMAP3_HS_USB_PORTS ; i++) {
> > > > + if (omap->port_mode[i] == EHCI_HCD_OMAP_MODE_UNKNOWN)
> > > > + continue;
> > > > + if (omap->regulator[i]) {
> > > > + if (regulator_is_enabled(omap->regulator[i]))
> > > > + regulator_disable(omap->regulator[i]);
> > > > + regulator_put(omap->regulator[i]);
> > > > + }
> > >
> > > For robustness I'd drop the first check for MODE_UNKNOWN here - it
> > > doesn't add anything.
> >
> > MODE_UNKNOWN means that the port is not connected and so no
> > need to check
> > the regulator availability.
>
> Ajay,
>
> It's better to check for EHCI_HCD_OMAP_MODE_PHY instead
> of EHCI_HCD_OMAP_MODE_UNKNOWN. The other option is
> EHCI_HCD_OMAP_MODE_TLL, and it will never use a regulator.
Ok fine, I will take this one also in next revision.
-Ajay
>
>
> Regards,
> Anand
>
> >
> > > You also want to call regulator_disable() before
> > > you free the regulator.
> >
> > It is being done under 'if (regulator_is_enabled)' check.
> >
> > -Ajay
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
