Hi Kevin On Tue, 17 Nov 2009, Kevin Hilman wrote:
> WARN if a clock/hwmod is missing a clockdomain association since > resulting hwmod will not be able to correctly enable/disable clocks. Wouldn't this check be best placed in the clock code? > > Signed-off-by: Kevin Hilman <[email protected]> > --- > arch/arm/mach-omap2/omap_hwmod.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod.c > b/arch/arm/mach-omap2/omap_hwmod.c > index 633b216..7d7b3b8 100644 > --- a/arch/arm/mach-omap2/omap_hwmod.c > +++ b/arch/arm/mach-omap2/omap_hwmod.c > @@ -326,6 +326,9 @@ static int _init_main_clk(struct omap_hwmod *oh) > ret = -EINVAL; > oh->_clk = c; > > + WARN(!c->clkdm, "omap_hwmod: %s: missing clockdomain for %s.\n", > + oh->clkdev_con_id, c->name); > + > return ret; > } > > -- > 1.6.5.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
