[email protected] said the following on 12/07/2009 10:54 AM:
> Hi,
>
> One comment below.
>
>
>> -----Original Message-----
>> From: [email protected]
>> [mailto:[email protected]] On Behalf Of ext
>> Nishanth Menon
>> Sent: 25 November, 2009 06:09
>> To: linux-omap
>> Cc: Nishanth Menon; Benoit Cousson; Kevin Hilman; Madhusudhan
>> Chikkature Rajashekar; Paul Walmsley; Romit Dasgupta; Sanjeev
>> Premi; Santosh Shilimkar; Sergio Alberto Aguirre Rodriguez;
>> Thara Gopinath; Vishwanath Sripathy
>> Subject: [PATCH 07/10 V3] omap3: clk: use pm accessor
>> functions for cpufreq table
>>
>> omap2_clk_init_cpufreq_table currently directly accesses the opp
>> table, making it unscalable to various OMAPs. Instead use the
>> accessor functions to populate the cpufreq table
>>
>> Cc: Benoit Cousson <[email protected]>
>> Cc: Kevin Hilman <[email protected]>
>> Cc: Madhusudhan Chikkature Rajashekar <[email protected]>
>> Cc: Paul Walmsley <[email protected]>
>> Cc: Romit Dasgupta <[email protected]>
>> Cc: Sanjeev Premi <[email protected]>
>> Cc: Santosh Shilimkar <[email protected]>
>> Cc: Sergio Alberto Aguirre Rodriguez <[email protected]>
>> Cc: Thara Gopinath <[email protected]>
>> Cc: Vishwanath Sripathy <[email protected]>
>>
>> Signed-off-by: Nishanth Menon <[email protected]>
>> ---
>> arch/arm/mach-omap2/clock34xx.c | 32
>> +++++++++++++++++++-------------
>> 1 files changed, 19 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/clock34xx.c
>> b/arch/arm/mach-omap2/clock34xx.c
>> index 5150939..d07f1c1 100644
>> --- a/arch/arm/mach-omap2/clock34xx.c
>> +++ b/arch/arm/mach-omap2/clock34xx.c
>> @@ -1042,30 +1042,36 @@ static unsigned long
>> omap3_clkoutx2_recalc(struct clk *clk)
>> #if defined(CONFIG_ARCH_OMAP3)
>>
>> #ifdef CONFIG_CPU_FREQ
>> -static struct cpufreq_frequency_table freq_table[MAX_VDD1_OPP+1];
>> +
>> +static struct cpufreq_frequency_table *freq_table;
>>
>> void omap2_clk_init_cpufreq_table(struct
>> cpufreq_frequency_table **table)
>> {
>> - struct omap_opp *prcm;
>> int i = 0;
>> + u8 opp_num;
>> + struct omap_opp *opp = NULL;
>> + unsigned long freq = ULONG_MAX;
>>
>> - if (!mpu_opps)
>> + if (!mpu_opps || opp_get_opp_count(&opp_num, mpu_opps)) {
>> + pr_warning("%s: failed to initialize frequency"
>> + "table\n", __func__);
>> return;
>> -
>> - prcm = mpu_opps + MAX_VDD1_OPP;
>> - for (; prcm->rate; prcm--) {
>> - freq_table[i].index = i;
>> - freq_table[i].frequency = prcm->rate / 1000;
>> - i++;
>> }
>>
>> - if (i == 0) {
>> - printk(KERN_WARNING "%s: failed to initialize
>> frequency \
>> -
>> table\n",
>> -
>> __func__);
>> + freq_table = kmalloc(sizeof(struct cpufreq_frequency_table) *
>> + (opp_num + 1), GFP_KERNEL);
>>
>
> I guess this should be GFP_ATOMIC, we have clockfw spinlock reserved when
> this is called (gave me a runtime warning.)
>
Thanks.. I must have missed the warning.. :( will check and add..
>
>> + if (!freq_table) {
>> + pr_warning("%s: failed to allocate frequency"
>> + "table\n", __func__);
>> return;
>> }
>>
>> + while (!opp_get_lower_opp(&opp, &freq, mpu_opps)) {
>> + freq_table[i].index = i;
>> + freq_table[i].frequency = freq / 1000;
>> + i++;
>> + }
>> +
>> freq_table[i].index = i;
>> freq_table[i].frequency = CPUFREQ_TABLE_END;
>>
>> --
>> 1.6.3.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-omap" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> --
>>
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
