On Fri, Dec 11, 2009 at 8:07 AM, Kevin Hilman <[email protected]> wrote: > Cory Maccarrone <[email protected]> writes: > > > I think this needs a little more description. In particular you > should describe that this toggle happens on *every* interrupt, and > why. > > Also, it's not exactly a noop for non-OMAP1. More on this below... > > ... > > Not exactly a noop. This function is called for non-OMAP1 as well... > > > ...and will write a zero to offset zero of the GPIO bank regs > (GPIO_REVISION reg). While ths is a read-only reg and *should* have > no effect, the point is that this function should not be called for > non-OMAP1. > > > Rather than check the flags on every interrupt, it may be better to > create a per-bank mask for GPIOs that need this treatment. > > The code that sets that flag could be conditional on OMAP1 and also on > whether both edges are set. >
Thanks for the feedback. This is the first time I've dealt with this code and I wanna make sure I get it right. I'll take another look at it and see what I can do. Thanks Cory -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
