On Fri, Jan 08, 2010 at 02:00:26AM +0100, Omar Ramirez Luna wrote:
> This patch cleans SSI clock preparation and also removes
> the dependency on IO_ADDRESS variants for easier maintenance.

So this patch is:
 * reorganizing SSI configuration
 * doing some code-style cleanups
 * using ioremap()

That doesn't look very atomic to me.

> Signed-off-by: Omar Ramirez Luna <omar.rami...@ti.com>
> ---
>  arch/arm/plat-omap/include/dspbridge/drv.h |    7 ++++++
>  drivers/dsp/bridge/services/clk.c          |   30 ++++++++++++++-------------
>  2 files changed, 23 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/include/dspbridge/drv.h 
> b/arch/arm/plat-omap/include/dspbridge/drv.h
> index d14613f..59c26fc 100644
> --- a/arch/arm/plat-omap/include/dspbridge/drv.h
> +++ b/arch/arm/plat-omap/include/dspbridge/drv.h
> @@ -115,6 +115,13 @@
>  #define OMAP_DMMU_BASE 0x5D000000
>  #define OMAP_DMMU_SIZE 0x1000
>  
> +#define OMAP_SSI_BASE                0x48058000
> +#define OMAP_SSI_SIZE                0x1000
> +
> +#define SSI_AUTOIDLE                 (1 << 0)
> +#define SSI_SIDLE_SMARTIDLE  (2 << 3)
> +#define SSI_MIDLE_NOIDLE             (1 << 12)
> +
>  #define OMAP_PRCM_VDD1_DOMAIN 1
>  #define OMAP_PRCM_VDD2_DOMAIN 2

Isn't this some abuse of arch/arm? In general things in header files are
meant to be used in more than one source file, and it doesn't seem
anybody would use these other than clk.c.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to