On Tue, Jan 19, 2010 at 7:52 PM, Hiremath, Vaibhav <[email protected]> wrote:
>
>> -----Original Message-----
>> From: [email protected] [mailto:linux-omap-
>> [email protected]] On Behalf Of Y, Kishore
>> Sent: Tuesday, January 19, 2010 6:42 PM
>> To: Tomi Valkeinen
>> Cc: [email protected]
>> Subject: [PATCH 1/2] OMAP: DSS: Add display board file for zoom
>> boards
>>
>> From: Kishore Y <[email protected]>
>>
>> board-zoom-display.c added as a common file for display
>> fucntionality
>> on boards zoom2, zoom3 and 3630sdp
>>
>> Signed-off-by: Mukund Mittal <[email protected]>
>> Signed-off-by: Kishore Y <[email protected]>
>> ---
>> arch/arm/mach-omap2/Makefile | 3 +
>> arch/arm/mach-omap2/board-zoom-display.c | 232
>> +++++++++++++++++++++++++
>> arch/arm/mach-omap2/board-zoom-peripherals.c | 36 ++++
>> arch/arm/mach-omap2/include/mach/board-zoom.h | 3 +
>> 4 files changed, 274 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-omap2/board-zoom-display.c
>>
>> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-
>> omap2/Makefile
>> index b32678b..3dbe694 100644
>> --- a/arch/arm/mach-omap2/Makefile
>> +++ b/arch/arm/mach-omap2/Makefile
>> @@ -91,14 +91,17 @@ obj-$(CONFIG_MACH_NOKIA_RX51) +=
>> board-rx51.o \
>> board-rx51-peripherals.o \
>> mmc-twl4030.o
>> obj-$(CONFIG_MACH_OMAP_ZOOM2) += board-zoom2.o \
>> + board-zoom-display.o \
>> board-zoom-peripherals.o \
>> mmc-twl4030.o \
>> board-zoom-debugboard.o
>> obj-$(CONFIG_MACH_OMAP_ZOOM3) += board-zoom3.o \
>> + board-zoom-display.o \
>> board-zoom-peripherals.o \
>> mmc-twl4030.o \
>> board-zoom-debugboard.o
>> obj-$(CONFIG_MACH_OMAP_3630SDP) += board-3630sdp.o \
>> + board-zoom-display.o \
>> board-zoom-peripherals.o \
>> mmc-twl4030.o
>> obj-$(CONFIG_MACH_CM_T35) += board-cm-t35.o \
>> diff --git a/arch/arm/mach-omap2/board-zoom-display.c
>> b/arch/arm/mach-omap2/board-zoom-display.c
>> new file mode 100644
>> index 0000000..c8f47f4
>> --- /dev/null
>> +++ b/arch/arm/mach-omap2/board-zoom-display.c
<snip>
>> +static int zoom_panel_enable_tv(struct omap_dss_device *dssdev)
>> +{
>> + int ret;
>> + struct regulator *vdac_reg;
>> +
>> + vdac_reg = regulator_get(NULL, "vdda_dac");
>> + if (IS_ERR(vdac_reg)) {
>> + pr_err("Unable to get vdac regulator\n");
>> + return PTR_ERR(vdac_reg);
>> + }
> [Hiremath, Vaibhav] Same here.
Actually you don't need this regulator_get() at all, DSS2 core already
calls it for you. With upcoming DSS2 updates you will not need
regulator_get() vpll2 too, so I guess it can already be removed too.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
