Hello Abhijit, Santosh,

On Tue, 16 Feb 2010, Santosh Shilimkar wrote:

> The mcbsp driver has been adapted for the OMAP4 way of clock calls.
> In OMAP4, the iclk are hw controlled and no sw control is available
> 
> Signed-off-by: Abhijit Pagare <[email protected]>
> Signed-off-by: Santosh Shilimkar <[email protected]>
> ---
>  arch/arm/plat-omap/mcbsp.c |   13 ++++++++-----
>  1 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index 473be3d..72b9694 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -1314,11 +1314,14 @@ static int __devinit omap_mcbsp_probe(struct 
> platform_device *pdev)
>       mcbsp->dma_rx_sync = pdata->dma_rx_sync;
>       mcbsp->dma_tx_sync = pdata->dma_tx_sync;
>  
> -     mcbsp->iclk = clk_get(&pdev->dev, "ick");
> -     if (IS_ERR(mcbsp->iclk)) {
> -             ret = PTR_ERR(mcbsp->iclk);
> -             dev_err(&pdev->dev, "unable to get ick: %d\n", ret);
> -             goto err_iclk;
> +     /* OMAP4 iclk are hw controlled and no sw control is available */
> +     if (!cpu_is_omap44xx()) {

Please use dummy_ck for this, rather than modifying plat-omap/mcbsp.c.

> +             mcbsp->iclk = clk_get(&pdev->dev, "ick");
> +             if (IS_ERR(mcbsp->iclk)) {
> +                     ret = PTR_ERR(mcbsp->iclk);
> +                     dev_err(&pdev->dev, "unable to get ick: %d\n", ret);
> +                     goto err_iclk;
> +             }
>       }
>  
>       mcbsp->fclk = clk_get(&pdev->dev, "fck");
> -- 
> 1.6.0.4
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to