* Aguirre, Sergio <[email protected]> [100219 15:52]: > Hi Tony, > > > -----Original Message----- > > From: Tony Lindgren [mailto:[email protected]] > > Sent: Friday, February 19, 2010 5:44 PM > > To: Aguirre, Sergio > > Cc: [email protected]; Felipe Balbi; linux- > > [email protected]; [email protected] > > Subject: Re: [PATCH 03/11] arm: omap: musb: ioremap only what's ours > > > > * Aguirre, Sergio <[email protected]> [100219 15:34]: > > > Hi, > > > > > > > -----Original Message----- > > > > From: [email protected] [mailto:linux-omap- > > > > [email protected]] On Behalf Of Tony Lindgren > > > > Sent: Friday, February 19, 2010 5:30 PM > > > > To: [email protected] > > > > Cc: Felipe Balbi; [email protected]; linux- > > [email protected] > > > > Subject: [PATCH 03/11] arm: omap: musb: ioremap only what's ours > > > > > > > > From: Felipe Balbi <[email protected]> > > > > > > > > omap3430 TRM says the OTG address space is 4k, not 8k. > > > > > > > > Cc: [email protected] > > > > Signed-off-by: Felipe Balbi <[email protected]> > > > > Signed-off-by: Tony Lindgren <[email protected]> > > > > --- > > > > arch/arm/mach-omap2/usb-musb.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb- > > > > musb.c > > > > index a80441d..ba71f76 100644 > > > > --- a/arch/arm/mach-omap2/usb-musb.c > > > > +++ b/arch/arm/mach-omap2/usb-musb.c > > > > @@ -152,7 +152,7 @@ void __init usb_musb_init(void) > > > > musb_resources[0].start = OMAP243X_HS_BASE; > > > > else > > > > musb_resources[0].start = OMAP34XX_HSUSB_OTG_BASE; > > > > - musb_resources[0].end = musb_resources[0].start + SZ_8K - 1; > > > > + musb_resources[0].end = musb_resources[0].start + SZ_4K - 1; > > > > > > I'm just curious... > > > > > > Is this valid also if cpu_is_243x() ? > > > > Yes, the other 4K is for the L4 interconnect. > > Ok... > > But then in this case, shouldn't these register boundaries come from a > platform specific header file? > > That would be cleaner, I believe, and easier to maintain in the long run. > > What do you think?
Yeah that will eventually get sorted out by hwmod. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
