Hi Aguilar, > -----Original Message----- > From: [email protected] [mailto:linux-omap- > [email protected]] On Behalf Of Aguilar Pena, Leed > Sent: Monday, February 22, 2010 5:55 PM > To: [email protected] > Cc: [email protected]; Hiroshi DOYU > Subject: [PATCH] omap: mailbox: unregister correct mbox device for > omap2420 > > label err_iva1 is defined to unregister the mbox device > for omap2420 which is contained in mbox_iva_info struct > > mbox_dsp_info is not being used by the omap2420 > > Signed-off-by: Leed Aguilar <[email protected]> > --- > arch/arm/mach-omap2/mailbox.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > Index: omap/arch/arm/mach-omap2/mailbox.c > =================================================================== > --- omap.orig/arch/arm/mach-omap2/mailbox.c 2010-02-22 > 17:41:24.000000000 -0600 > +++ omap/arch/arm/mach-omap2/mailbox.c 2010-02-22 17:51:31.000000000 - > 0600 > @@ -420,7 +420,7 @@ > return 0; > > err_iva1: > - omap_mbox_unregister(&mbox_dsp_info); > + omap_mbox_unregister(&mbox_iva_info);
The err_iva1 label is indicating that the iva1 registration has failed, and you need to free the previously registered dsp. So, this patch is not valid. > > err_dsp: > iounmap(mbox_base); > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards Suman -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
