> -----Original Message----- > From: [email protected] [mailto:linux-omap- > [email protected]] On Behalf Of Aguirre, Sergio > Sent: Friday, March 05, 2010 5:12 PM > To: Kevin Hilman > Cc: [email protected] > Subject: RE: [RFC part1/2 merge][PATCH 06/10] omap3: serial: Fix uart4 > handling for 3630 > > > From: Kevin Hilman [mailto:[email protected]] > Sent: Friday, March 05, 2010 4:38 PM > > <snip> > > > > @@ -694,6 +698,10 @@ void __init omap_serial_early_init(void) > > > > > > if (cpu_is_omap44xx()) > > > p->irq += 32; > > > + > > > + /* IRQ for UART4 in omap3630 is 80 */ > > > + if (cpu_is_omap3630() && (i == 3)) > > > + p->irq = 80; > > > > Should add a symbolic name to irqs.h and use it here, instead > > of hard-coded constant. > > Sounds like a nice idea! Thanks! > > I'll update the patchset and resend.
Actually, I have been thinking on a patch to remove all magic numbering, also for OMAP4... I'll think about it and include it in the next version. Regards, Sergio > > Regards, > Sergio > > > > Kevin > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
