On Tue, Mar 23, 2010 at 07:07:31PM +0100, ext Kevin Hilman wrote:
Felipe Balbi <[email protected]> writes:

Convert the omap32k clocksource driver into a platform_driver
and while at that, also remove the ifdeferry around the code.

Signed-off-by: Felipe Balbi <[email protected]>

Looks like a good direction, but it still is rather tied to the 32k
sync timer.  We also have the ability to use a GPtimer as a
clocksource (see the clocksource register in timer-gp.c.)  By default,
we are always using the 32k timer for PM reasons, but we need the ability
to register any timer as clocksource.  This problably means just splitting
a little more the driver part and the device part.

Also, the new clocksource.c file should reference from whence it came.
A lot of that was copy/pasted from the older code so copyrights/author
credits should follow.

all add back the credits, missed that sorry but I believe the gp timer part is subject to another patch, no ? Otherwise this will start to become one huge unreviewable patch.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to