On Thu, Mar 25, 2010 at 11:37 PM, Hebbar, Shivananda <[email protected]> wrote: >> love the cleanup *but*: >> arch/arm/plat-omap/include/dspbridge/dbdefs.h:typedef u32 dsp_status; >> 1) All usage of dsp_status should be changed to int > > Looks like MM code uses this variable. Even MM code needs to be changed for > this. But changes are minimal.
What do you mean by MM uses this variable? If you mean user-space (omx, gst-dsp), then no, error codes are passed through ioctl, which returns an int. And anyway on 32bit dsp_status = u32 = int. >> 2) You should be using -Exxxx instead of Exxxxx in all the patches. > Ok!! Yeah, otherwise DSP_FAILED will fail. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
