From: Deepak Chitriki <[email protected]> cpufreq_register_notifier() function calls srcu_notifier_chain_register() which always returns 0 on success and dspbridge throws the error message "clk_notifier_register failed for iva2_ck". Fix the faulty ! in if logic and the faulty error message we report to log.
Cc: Ameya Palande <[email protected]> Cc: Andy Shevchenko <[email protected]> Cc: Deepak Chitriki <[email protected]> Cc: Fernando Guzman Lugo <[email protected]> Cc: Felipe Contreras <[email protected]> Cc: Hari Kanigeri <[email protected]> Cc: Hiroshi Doyu <[email protected]> Cc: Omar Ramirez Luna <[email protected]> Cc: Ramesh Gupta <[email protected]> Signed-off-by: Deepak Chitriki <[email protected]> --- drivers/dsp/bridge/rmgr/drv_interface.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c index 61aa13a..388c07a 100644 --- a/drivers/dsp/bridge/rmgr/drv_interface.c +++ b/drivers/dsp/bridge/rmgr/drv_interface.c @@ -351,10 +351,10 @@ static int __devinit omap34_xx_bridge_probe(struct platform_device *pdev) if (!clk_handle) pr_err("%s: clk_get failed to get iva2_ck\n", __func__); - if (!cpufreq_register_notifier(&iva_clk_notifier, + if (cpufreq_register_notifier(&iva_clk_notifier, CPUFREQ_TRANSITION_NOTIFIER)) - pr_err("%s: clk_notifier_register failed for iva2_ck\n", - __func__); + pr_err("%s: cpufreq_register_notifier failed for " + "iva2_ck\n", __func__); #endif driver_context = dsp_init(&init_status); if (DSP_FAILED(init_status)) { @@ -393,9 +393,9 @@ static int __devexit omap34_xx_bridge_remove(struct platform_device *pdev) goto func_cont; #ifdef CONFIG_BRIDGE_DVFS - if (!cpufreq_unregister_notifier(&iva_clk_notifier, + if (cpufreq_unregister_notifier(&iva_clk_notifier, CPUFREQ_TRANSITION_NOTIFIER)) - pr_err("%s: clk_notifier_unregister failed for iva2_ck\n", + pr_err("%s: cpufreq_unregister_notifier failed for iva2_ck\n", __func__); #endif /* #ifdef CONFIG_BRIDGE_DVFS */ -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
