Hello Laine,

two minor comments:

On Tue, 6 Apr 2010, Laine Walker-Avina wrote:

> 
> Signed-off-by: Laine Walker-Avina <[email protected]>

Please add a brief changelog.  Nothing fancy needed...

> ---
>  arch/arm/mach-omap2/clock3xxx_data.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock3xxx_data.c 
> b/arch/arm/mach-omap2/clock3xxx_data.c
> index d5153b6..2a62779 100644
> --- a/arch/arm/mach-omap2/clock3xxx_data.c
> +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> @@ -1111,6 +1111,7 @@ static struct clk sys_clkout2 = {
>       .clksel_mask    = OMAP3430_CLKOUT2_DIV_MASK,
>       .clksel         = sys_clkout2_clksel,
>       .recalc         = &omap2_clksel_recalc,

Please add a .round_rate function pointer here also, pointing to 
omap2_clksel_round_rate.

> +     .set_rate       = &omap2_clksel_set_rate,
>  };
>  
>  /* CM OUTPUT CLOCKS */
> -- 
> 1.6.3.3


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to