On Thu, 29-Apr-10 3:00 AM +0530, Kevin Hilman wrote: > Ranjith Lohithakshan <[email protected]> writes: > >> Currently on PM branch, compilation fails when cpufreq is disabled >> >> arch/arm/mach-omap2/clock3xxx_data.c: In function 'omap3xxx_clk_init': >> arch/arm/mach-omap2/clock3xxx_data.c:3563: error: 'struct clk_functions' >> has no member named 'clk_init_cpufreq_table' >> arch/arm/mach-omap2/clock3xxx_data.c:3564: error: >> 'omap3_clk_init_cpufreq_table' undeclared (first use >> in this function) >> arch/arm/mach-omap2/clock3xxx_data.c:3564: error: (Each undeclared >> identifier is reported only once >> arch/arm/mach-omap2/clock3xxx_data.c:3564: error: for each function it >> appears in.) >> make[1]: *** [arch/arm/mach-omap2/clock3xxx_data.o] Error 1 >> make: *** [arch/arm/mach-omap2] Error 2 >> >> This patch fixes the issue by avoiding runtime init of >> clk_init_cpufreq_table in omap3xxx_clk_init and instead doing it when >> omap2_clk_functions are defined. >> >> Signed-off-by: Ranjith Lohithakshan <[email protected]> > > Do you still have this problem? I'm unable to reproduce on current PM branch.
No, I don't see this now. Might have got fixed in some of the recent changes. Just FYI, I now see a linkage error with omap3_evm_defconfig arch/arm/mach-omap2/built-in.o: In function `sr_configure_vp': /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:315: undefined reference to `omap_twl_uv_to_vsel' /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:364: undefined reference to `omap_twl_uv_to_vsel' arch/arm/mach-omap2/built-in.o: In function `sr_enable': /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:609: undefined reference to `omap_twl_uv_to_vsel' arch/arm/mach-omap2/built-in.o: In function `sr_reset_voltage': /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:478: undefined reference to `omap_twl_uv_to_vsel' /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:496: undefined reference to `omap_twl_uv_to_vsel' make: *** [.tmp_vmlinux1] Error 1 - Ranjith -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
