* Ohad Ben-Cohen <[email protected]> [100502 08:40]:
> Fix reverse likeliness
> 
> Signed-off-by: Ohad Ben-Cohen <[email protected]>
> ---
> If you want, you can also reach me at < ohadb at ti dot com >.
> 
>  arch/arm/plat-omap/mailbox.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
> index 5140efc..5309213 100644
> --- a/arch/arm/plat-omap/mailbox.c
> +++ b/arch/arm/plat-omap/mailbox.c
> @@ -290,7 +290,7 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
>   fail_alloc_txq:
>       free_irq(mbox->irq, mbox);
>   fail_request_irq:
> -     if (unlikely(mbox->ops->shutdown))
> +     if (likely(mbox->ops->shutdown))
>               mbox->ops->shutdown(mbox);
>  
>       return ret;
> @@ -303,7 +303,7 @@ static void omap_mbox_fini(struct omap_mbox *mbox)
>  
>       free_irq(mbox->irq, mbox);
>  
> -     if (unlikely(mbox->ops->shutdown)) {
> +     if (likely(mbox->ops->shutdown)) {
>               spin_lock(&mboxes_lock);
>               if (mbox_configured > 0)
>                       mbox_configured--;

Does this code path need to be optimized? :)

How about just get rid of the (un)likely here?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to