* Arce, Abraham <[email protected]> [100505 01:06]: > Manjunath, > > > > + > > > +static void omap_ethernet_init(void) > > > +{ > > > + gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet"); > > > + gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1); > > > + gpio_request(ETHERNET_KS8851_QUART, "quart"); > > > + gpio_direction_output(ETHERNET_KS8851_QUART, 1); > > > + gpio_request(ETHERNET_KS8851_IRQ, "ks8851"); > > > > Any reason for not checking return value of gpio_request()? > > > > Thought initially about them as dedicated lines for ethernet avoiding > both reasons to check for a gpio's request: > > 1. invalid gpio > 2. already claimed gpio
You still need to check for the result. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
