Kevin, > > -----Original Message----- > > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > > Sent: Saturday, May 01, 2010 4:33 AM > > To: Varadarajan, Charulatha > > Cc: linux-omap@vger.kernel.org; Nayak, Rajendra; p...@pwsan.com; > t...@atomide.com > > Subject: Re: [PATCH 5/9] OMAP:GPIO: Introduce support for OMAP2PLUS chip > specific > > GPIO > > > > Charulatha V <ch...@ti.com> writes: > > > > > This patch adds support for handling GPIO as a HWMOD adapted > > > platform device for OMAP2PLUS chips. > > > > > > Signed-off-by: Charulatha V <ch...@ti.com> > > > --- > > > arch/arm/mach-omap2/gpio.c | 101 > ++++++++++++++++++++++++++++++++++++++++++++ > > > 1 files changed, 101 insertions(+), 0 deletions(-) > > > create mode 100644 arch/arm/mach-omap2/gpio.c > > > > > > diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c > > > new file mode 100644 > > > index 0000000..6424050 > > > --- /dev/null > > > +++ b/arch/arm/mach-omap2/gpio.c > > > @@ -0,0 +1,101 @@
..[snip].. > > > + if (cpu_is_omap24xx() || cpu_is_omap34xx()) > > > + pdata->method = METHOD_GPIO_24XX; > > > + if (cpu_is_omap44xx()) > > > + pdata->method = METHOD_GPIO_44XX; > > > + pdata->virtual_irq_start = IH_GPIO_BASE + 32 * i; > > > + pdata->device_enable = omap_device_enable; > > > + pdata->device_idle = omap_device_idle; > > > + pdata->device_shutdown = omap_device_shutdown; > > > > These aren't valid for GPIO1 which is in WKUP. Maybe we need > > to check if the hwmod is not in wkup_pwrdm before setting these? > > I need to check how to implement this. > There are two ways to implement this: 1. Use a flag in dev_attr of the device to indicate if the device belongs to WKUP domain 2. We can add an API in powerdomain FW to provide information if the device belongs to a "always_on" domain or otherwise, and use this API for each device. Kindly suggest. -V Charulatha -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
