Tomi,
> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On Behalf Of
> Guruswamy, Senthilvadivu
> Sent: Monday, May 17, 2010 11:20 AM
> To: Tomi Valkeinen
> Cc: [email protected]; [email protected];
> [email protected]; Hiremath, Vaibhav
> Subject: RE: [PATCH v2 0/2] DSS2:Allow FB to build without VRFB
>
>
>
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:[email protected]]
> > Sent: Friday, May 14, 2010 6:32 PM
> > To: Guruswamy, Senthilvadivu
> > Cc: [email protected]; [email protected];
> > [email protected]; Hiremath, Vaibhav
> > Subject: RE: [PATCH v2 0/2] DSS2:Allow FB to build without VRFB
> >
> > On Fri, 2010-05-14 at 12:03 +0200, ext Guruswamy,
> Senthilvadivu wrote:
> > >
> > > > -----Original Message-----
> > > > From: Tomi Valkeinen [mailto:[email protected]]
> > > > Sent: Friday, May 14, 2010 12:54 PM
> > > > To: Guruswamy, Senthilvadivu
> > > > Cc: [email protected]; [email protected];
> > > > [email protected]; Hiremath, Vaibhav
> > > > Subject: Re: [PATCH v2 0/2] DSS2:Allow FB to build without VRFB
> >
> > <snip>
> >
> >
> > If it's possible to turn VRFB off, then the code should
> > handle the case
> > where VRFB is not there. Meaning, returning error values or
> > somehow else
> > failing gracefully, and informing the user of wrong arguments.
> >
> [Senthil] Yes, I could provide a check in the driver for
> wrong arguments.
[Senthil] I have 2 options to make this check. I am now evaluating
the OMAP_HAS_FEATURE patch from Nishant to see if it could be used
to extend for VRFB before I send this patch.
Option 1:
In omapfb-main.c - in omapfb_probe()
/* Patches required on top of Nishant Menon's HAS_FEATURE */
if (def_vrfb && !OMAP_HAS_FEATURE(VRFB)) {
def_vrfb = 0;
printk(warning);
}
And OMAP_HAS_FEATURE(VRFB) in id.c
Option 2:
/*TODO : Replace cpu check with OMAP_HAS_FEATURE */
if ( def_vrfb && ! (cpu_is_omap24xx || cpu_is_omap34xx) ) {
def_vrfb = 0;
printk(warning);
}
Regards,
Senthil
