On Mon, Jun 7, 2010 at 6:14 PM, Guzman Lugo, Fernando
<fernando.l...@ti.com> wrote:
> I think the best thing to do here is remove the spinlock

I'm afraid we can't do that: we need it to support OMAP4 syslink IPC
use cases which have multiple simultaneous sending contexts.


>, if not, you are preventing that omap_mbox_msg_send be executed from a 
>tasklet or isr context.


Right. But this is pretty standard - you can't call every kernel API
from every possible context - the allowed calling context is part of
the API. If later we decide we need to add additional calling
contexts, it's ok - it's just like changing the API.


> Why not remove the workqueue at all and let the mailbox module user be the 
> judge for using tasklet, workqueue or do the job in the same isr (if it is 
> small task and need to be fast)?


hmm I'm not following here - will you please elaborate on this a bit more ?


Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to