On 06/20/2010 09:42 AM, Suresh Rajashekara wrote: > On Sun, Jun 20, 2010 at 12:23 AM, Jiri Slaby <[email protected]> wrote: >> On 06/20/2010 08:52 AM, Suresh Rajashekara wrote: >>> The ioctl waits on a completion variable (using >>> wait_for_completion_interruptible). >> ... >>> I tried wait_for_completion instead, but now the kernel refuses to suspend. >> >> Do you check return value of wait_for_completion_interruptible and >> return its value if nonzero? >> >> We need the code to comment, otherwise it's hard to say. > > No. I am not checking the return value of the > wait_for_completion_interruptible. I can do it
I thought so. Generally, all *_interruptible functions return a value which should be checked and propagated to upper layers. -- js -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
