Paul Walmsley <[email protected]> writes: > Hi Kevin, > > something doesn't make sense in this patch... > > On Wed, 23 Jun 2010, Kevin Hilman wrote: > >> If an omap_hwmod is setup using HWMOD_INIT_NO_IDLE flag, there is >> currently way to idle it since omap_hwmod_idle() requires the hwmod to >> be in the enabled state. > > The only thing that HWMOD_INIT_NO_IDLE does is prevent the hwmod from > being idled at the end of _setup(). By that time, the hwmod has already > been enabled, and its state has been set to _HWMOD_STATE_ENABLED. So > there shouldn't be anything preventing the hwmod from being idled at that > point? > > Maybe the problem is that some hwmods were failing _wait_target_ready() > and so were never entering the ENABLED state? If so, that looks like it's > fixed appropriately by your patch 3.
Hmm, strange. Indeed, this patch predates patch 3, so may not be necessary anymore. I will check into it. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
