* Ghorai, Sukumar <s-gho...@ti.com> [100707 15:26]: > > From: Tony Lindgren [mailto:t...@atomide.com] > > > > You should just replace this function with simple functions like we > > already > > have in gpmc.c rather than trying to pack everything into one function. > > Just add various gpmc_xxx_get/set functions rather than pass int *rval. > > [Ghorai] So I was having the same query very 1st time. > So we need to implement 15 separate functions to do the same as you > suggested. And in my approach it's very easy to enhance the functionally in > future, say to add new set/get. E.g. we need the similar cleanup for OneNAND > code too. > So, would you please confirm once again with one is the best and should > follow?
In general, we should have separate read and write functions. Maybe you can group them a little bit? Some of them need the chip select, and some of them are generic. Then some of them are NAND specific. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
