> -----Original Message-----
> From: Taneja, Archit
> Sent: Friday, July 23, 2010 11:17 AM
> To: Hiremath, Vaibhav; [email protected]
> Cc: [email protected]; Semwal, Sumit; Mittal, Mukund
> Subject: RE: [PATCH 4/5] OMAP: DSS2: Video3 pipeline IRQs
>
>
>
> > -----Original Message-----
> > From: Hiremath, Vaibhav
> > Sent: Friday, July 23, 2010 11:10 AM
> > To: Taneja, Archit; [email protected]
> > Cc: [email protected]; Semwal, Sumit; Mittal,
> > Mukund; Taneja, Archit
> > Subject: RE: [PATCH 4/5] OMAP: DSS2: Video3 pipeline IRQs
> >
>
> <snap>
>
> > > @@ -173,7 +173,8 @@ struct dispc_reg { u16 idx; };
> > > DISPC_IRQ_SYNC_LOST | \
> > > DISPC_IRQ_SYNC_LOST_DIGIT | \
> > > (cpu_is_omap44xx() ? \
> > > - DISPC_IRQ_SYNC_LOST_2 : 0))
> > > +
> > (DISPC_IRQ_VID3_FIFO_UNDERFLOW | \
> > > + DISPC_IRQ_SYNC_LOST_2) : 0))
> > [Hiremath, Vaibhav] This looks bit suspicious to me, against
> > which tree this patch has been generated? I think you have
> > missed some of the patches in between.
>
> [Archit] This patch series sits over a previously sent RFC:
>
> https://patchwork.kernel.org/patch/111901/
>
[Hiremath, Vaibhav] Ohhh, I missed it completely. Perhaps it would be good if
you could mention this dependency in you PATCH [0/x].
I think Sanjeev has already provided some comments, so I would rather prefer to
review latest version (when you post it again).
Thanks,
Vaibhav
> >
> > >
> > > #define DISPC_MAX_NR_ISRS 8
> > >
> > > @@ -2540,6 +2541,8 @@ void dispc_dump_irqs(struct seq_file *s)
> > > PIS(VSYNC2);
> > > PIS(ACBIAS_COUNT_STAT2);
> > > PIS(SYNC_LOST_2);
> > > + PIS(VID3_FIFO_UNDERFLOW);
> > > + PIS(VID3_END_WIN);
> > > }
> > > #undef PIS
> > > }
> > > @@ -3151,6 +3154,24 @@ static void dispc_error_worker(struct
> > > work_struct
> > > *work)
> > > }
> > > }
> > >
> > > + if (errors & DISPC_IRQ_VID3_FIFO_UNDERFLOW) {
> > > + DSSERR("VID3_FIFO_UNDERFLOW, disabling VID2\n");
> > [Hiremath, Vaibhav] typo mistake VID2 => VID3
> >
> > Thanks,
> > Vaibhav
>
> Will fix this.
>
> Thanks,
>
> Archit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
