> -----Original Message-----
> From: Felipe Balbi [mailto:[email protected]]
> Sent: Monday, August 02, 2010 6:22 PM
> To: Datta, Shubhrajyoti
> Cc: [email protected]; Tony Lindgren
> Subject: Re: [PATCH] [RFC] Remove the debug print noise
>
> Hi,
>
> On Mon, Aug 02, 2010 at 02:47:51PM +0200, ext Shubhrajyoti D wrote:
> >@@ -626,7 +626,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter
> *adap,
> > if (r < 0)
> > return r;
> > if (r == 0) {
> >- dev_err(dev->dev, "controller timed out\n");
> >+ dev_dbg(dev->dev, "controller timed out\n");
>
> you would better be searching for the cause of the timeout. 1 second is
> enough time (or should be) for any i2c command to complete. If you have
> an easy way to reproduce this problem, then better search for its
> rootcause. If I remember correctly, this timeout was put here for a good
> reason.
The reason I am getting the timeout is that there isn't a device to respond in
that address However
# ./i2cdetect -y -r 3
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- 29 -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- 48 -- -- 4b -- -- -- --
Is more readable than
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- i2c_omap i2c_omap.3: controller timed out
-- -- i2c_omap i2c_omap.3: controller timed out
-- -- i2c_omap i2c_omap.3: controller timed out
-- -- i2c_omap i2c_omap.3: controller timed out
-- -- i2c_omap i2c_omap.3: controller timed out
-- -- i2c_omap i2c_omap.3: controller timed out
-- --
> Tony, any comments ?
>
> --
> balbi
>
> DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
