Re: [PATCH v2] OMAP3630: Add ES1.1 and ES1.2 detection

[Felipe Balbi]

hi,

On Wed, Aug 04, 2010 at 12:51:39PM +0200, ext Tony Lindgren wrote:

diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index fd1904b..0a0ff0c 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -269,11 +269,29 @@ static void __init omap3_check_revision(void)
                omap_chip.oc |= CHIP_IS_OMAP3430ES3_1;
                break;
        case 0xb891:
+               /* Handle 36xx devices */
+               omap_chip.oc |= CHIP_IS_OMAP3630ES1;
+
+               switch(rev) {
+               case 0: /* Take care of early samples */
+                       omap_revision = OMAP3630_REV_ES1_0;
+                       break;
+               case 1:
+                       omap_revision = OMAP3630_REV_ES1_1;
+                       omap_chip.oc |= CHIP_IS_OMAP3630ES1_1;
+                       break;
+               case 2:
+                       omap_revision =  OMAP3630_REV_ES1_2;
+                       omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
+                       break;
+               default:
+                       /* FALLTHROUGH */

did you forget a break here

+               }
        /* FALLTHROUGH */
        default:
                /* Unknown default to latest silicon rev as default*/
-               omap_revision = OMAP3630_REV_ES1_0;
-               omap_chip.oc |= CHIP_IS_OMAP3630ES1;
+               omap_revision =  OMAP3630_REV_ES1_2;
+               omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;

and here ?

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html