On Fri, 13 Aug 2010 07:21:08 -0500
Robert Nelson <[email protected]> wrote:

> +     /* Older U-Boot's such as 2009.01-dirty don't have the pins 
> +      * muxed correctly to use the generic gpio_direction_input();
> +      */
> +     omap_mux_init_gpio(171, OMAP_PIN_INPUT_PULLUP);
> +     omap_mux_init_gpio(172, OMAP_PIN_INPUT_PULLUP);
> +     omap_mux_init_gpio(173, OMAP_PIN_INPUT_PULLUP);
> +

Comment (and code) is wrong: gpio_direction_input is still required to
setup pin direction and letting the gpiolib to setup internal data
structures properly. I.e. both mux setup and gpio_direction_input are
required.


-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to