> -----Original Message-----
> From: Kevin Hilman [mailto:[email protected]]
> Sent: Tuesday, August 31, 2010 9:32 PM
> To: Datta, Shubhrajyoti
> Cc: [email protected]
> Subject: Re: [PATCH] omap: 4430sdp board support for the the GPIO keys
> 
> Shubhrajyoti D <[email protected]> writes:
> 
> > omap 4430sdp board support for the GPIO keys.
> > The proximity sensor is connected to GPIO and is registered as a
> > GPIO key.
> > - Making the default state of the sensor off at bootup
> > - The init is called before platform_add_devices
> >
> > Signed-off-by: Shubhrajyoti D <[email protected]>
> 
> I still think the subject is wrong:  You're adding support for the
> proximity sensor *using* GPIO keys, not adding support for GPIO keys:
> 
>     OMAP: 4430SDP: add proximity sensor via GPIO keys
> 
> or something like that.
Yes agree just sent a patch attempting to correct it.
Thanks,
> 
> Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to