On Tue, Aug 24, 2010 at 11:53:38PM -0400, Jacob Tanenbaum wrote:
> From: jake <j...@glados.(none)>

Not a valid address... please fix.

> 
>       ARM: OMAP3LOGIC: Adding SDMMC support
>              Add low-level initialization for hsmmc controller for
>              LogicPD's OMAP 3530 LV SOM and OMAP 35x Torpedo board.
> 
>       Tested against: 81e09f50c93edff607259cbe374a3006c9c5fa74
>       Signed-off-by: Jacob Tanenbaum <[email protected]>

I'm confused why these comments are indented.

> +static void __init board_mmc_init(void)
> +{
> +     /* OMAP3530 LV SOM board */
> +     if (machine_is_omap3530_lv_som()) {
> +             board_mmc_info[0].gpio_cd = OMAP3530_LV_SOM_MMC_GPIO_CD;
> +             board_mmc_info[0].gpio_wp = OMAP3530_LV_SOM_MMC_GPIO_WP;
> +             omap_mux_init_signal("gpio_110", OMAP_PIN_OUTPUT);
> +             omap_mux_init_signal("gpio_126", OMAP_PIN_OUTPUT);
> +
> +
> +     /* OMAP3 Torpedo board */

missing tab?

> +     } else if (machine_is_omap3_torpedo()) {
> +             board_mmc_info[0].gpio_cd = OMAP3_TORPEDO_MMC_GPIO_CD;
> +             omap_mux_init_signal("gpio_127", OMAP_PIN_OUTPUT);
> +     /* unsupported board */

missing tab?

> +     } else {
> +             printk(KERN_ERR "%s(): unknown machine type\n", __func__);
> +     return;

missing tab?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to