>>-----Original Message----- >>From: Menon, Nishanth >>Sent: Thursday, September 16, 2010 7:37 PM >>To: Gopinath, Thara >>Cc: Kevin Hilman; linux-omap@vger.kernel.org; >>linux-arm-ker...@lists.infradead.org >>Subject: Re: [PATCH 2/4] OMAP: OPP: twl/tps: Introduce TWL/TPS-specific code >> >>Gopinath, Thara had written, on 09/16/2010 08:51 AM, the following: >>> >>>>> -----Original Message----- >>>>> From: Menon, Nishanth >>>>> Sent: Thursday, September 16, 2010 5:45 PM >>>>> To: Gopinath, Thara >>>>> Cc: Kevin Hilman; linux-omap@vger.kernel.org; >>>>> linux-arm-ker...@lists.infradead.org >>>>> Subject: Re: [PATCH 2/4] OMAP: OPP: twl/tps: Introduce TWL/TPS-specific >>>>> code >>>>> >>>>> Gopinath, Thara had written, on 09/16/2010 05:40 AM, the following: >>>>>>>> -----Original Message----- >>>>>>>> From: linux-omap-ow...@vger.kernel.org >>>>>>>> [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of >>>>> Kevin >>>>>>>> Hilman >>>>>>>> Sent: Thursday, September 16, 2010 3:27 AM >>>>>>>> To: linux-omap@vger.kernel.org >>>>>>>> Cc: linux-arm-ker...@lists.infradead.org >>>>>>>> Subject: [PATCH 2/4] OMAP: OPP: twl/tps: Introduce TWL/TPS-specific >>>>>>>> code >>>>>>>> >>>>>>>> From: Paul Walmsley <p...@pwsan.com> >>>>>>>> >>>>>>>> The OPP layer code should be independent of the PMIC, >>>>>>>> introduce the TWL/TPS-specific code out to its own file. >>>>>> Hello Kevin, >>>>>> >>>>>> I have been using this code for a while now. I really do not think wee >>>>>> need a separate >>>>>> file for implementing the vsel to voltage in (uV) and vice versa >>>>>> formulas. Today only voltage >>>>> This split introduces a PMIC level abstraction already. Do you have a >>>>> suggestion which file it should go to? It is definitely not part of >>>>> opp.c, not part of other existing twl files as well. the job of this >>>>> file was to introduce conversion routines which can be used by any layer >>>>> (voltage layer if need be - it used to be srf and smartreflex before).. >>>>> in fact one of your voltage layer patches introduces capability for 6030 >>>>> as well >>>>> http://marc.info/?l=linux-omap&m=128213020927919&w=2 >>> >>> Yes one of my patches has introduces this coz I had no other way >>> to add OMAP4 support. But I still do not understand why cant these >>> APIs be implemented in twl-core.c or twl4030-power.c? >>Why there? Twl power does regulator operations not conversion >>operations. core is not the place either as it is function independent.
Hello Nishant, Why do you say core is not the place. For me core is exactly the place. It is the PMIC driver file. Regards Thara -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
