On Fri, Sep 24, 2010 at 2:45 PM, Benoit Cousson <[email protected]> wrote: > omap_mux_read / omap_mux_write should not be accessed directly > outside the mux framework. > Do we really have use case that require dynamic mux change beside > GPIO? >
Only case I can think of is for any workarounds for issues that turn up. No such cases exist today on OMAP3 at least, and none are likely to appear in future (I hope). So your assumption is valid. - Anand > Signed-off-by: Benoit Cousson <[email protected]> > Cc: Tony Lindgren <[email protected]> > Cc: Paul Walmsley <[email protected]> > Cc: Kevin Hilman <[email protected]> > --- > arch/arm/mach-omap2/mux.c | 4 ++-- > arch/arm/mach-omap2/mux.h | 18 ------------------ > 2 files changed, 2 insertions(+), 20 deletions(-) > > diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c > index 83e7686..8285cb8 100644 > --- a/arch/arm/mach-omap2/mux.c > +++ b/arch/arm/mach-omap2/mux.c > @@ -55,7 +55,7 @@ static u8 omap_mux_flags; > static struct mux_partition mux_partitions[MAX_PARTITIONS_NR]; > static u32 mux_partitions_cnt; > > -u16 omap_mux_read(u16 reg, u8 id) > +static u16 omap_mux_read(u16 reg, u8 id) > { > void __iomem *mux_base = mux_partitions[id].base; > > @@ -65,7 +65,7 @@ u16 omap_mux_read(u16 reg, u8 id) > return __raw_readw(mux_base + reg); > } > > -void omap_mux_write(u16 val, u16 reg, u8 id) > +static void omap_mux_write(u16 val, u16 reg, u8 id) > { > void __iomem *mux_base = mux_partitions[id].base; > > diff --git a/arch/arm/mach-omap2/mux.h b/arch/arm/mach-omap2/mux.h > index 9b28576..da67501 100644 > --- a/arch/arm/mach-omap2/mux.h > +++ b/arch/arm/mach-omap2/mux.h > @@ -173,24 +173,6 @@ u16 omap_mux_get_gpio(int gpio); > void omap_mux_set_gpio(u16 val, int gpio); > > /** > - * omap_mux_read() - read mux register > - * @mux_offset: Offset of the mux register > - * @id: identifier of the control module partition > - * > - */ > -u16 omap_mux_read(u16 mux_offset, u8 id); > - > -/** > - * omap_mux_write() - write mux register > - * @val: New mux register value > - * @mux_offset: Offset of the mux register > - * @id: identifier of the control module partition > - * > - * This should be only needed for dynamic remuxing of non-gpio signals. > - */ > -void omap_mux_write(u16 val, u16 mux_offset, u8 id); > - > -/** > * omap_mux_write_array() - write an array of mux registers > * @board_mux: Array of mux registers terminated by MAP_MUX_TERMINATOR > * > -- > 1.6.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
