On Fri, Oct 01, 2010 at 02:16:53PM +0200, Peter Ujfalusi wrote:
> On Friday 01 October 2010 14:50:37 David Cohen wrote:
> > 
> > > +         l = sys_cf = dma_read(OCP_SYSCONFIG);
> > 
> > Shouldn't it be avoided?
> 
> I'm restoring the OCP_SYSCONFIG register later on, and reusing 'l' here to 
> avoid 
> confusing expression when moving the sDMA to NoStandby.
> I could as well introduce other variable for this...

No problem with those two variables, but you're doing multiple
assignments in one line. You could do something like this:

l = dma_read(OCP_SYSCONFIG);
sys_cf = l;

Regards,

David
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to