> Liam Girdwood wrote: > > On Fri, 2010-09-24 at 11:31 -0500, Lopez Cruz, Misael wrote: > > > Hi Jarkko, > > > > > > > ASoC Multi-Component Support moves some code from > > > > sound/soc/omap/zoom2.c > > > > into > > > > arch/arm/mach-omap2/board-zoom2.c. However, that code should go to > > > > board-zoom-peripherals.c instead as there is common code and > > > > registration > > > > for zoom boards. > > > > > > > > Signed-off-by: Jarkko Nikula <[email protected]> > > > > Cc: Vikram Pandita <[email protected]> > > > > Cc: Lopez Cruz, Misael <[email protected]> > > > > Cc: Jorge Eduardo Candelaria <[email protected]> > > > > Cc: Tony Lindgren <[email protected]> > > > > --- > > > > I don't have this HW so not tested. > > > Tested on zoom2 using the 2 patches of your series, compilation break > is > > > gone and audio works fine. > > > > > > Thanks, > > > -Misael > > > > Applied, and manually added your Tested-by: > > > > Thanks > > > > Liam > > Misael, Liam, > > Sorry I noticed this patch only now. I have a minor comment on the patch: > > Specifically, the part below > > + if (machine_is_omap_zoom2()) { > + zoom_audio_data.ramp_delay_value = 3; /* 161 ms */ > + zoom_audio_data.hs_extmute = 1; > + zoom_audio_data.set_hs_extmute = zoom2_set_hs_extmute; > + } > > Isn't the audio on a zoom2/zoom3/3630 SDP the same? (Or at least the > same on a zoom2 and zoom3)? Yes, at least zoom2 and zoom3 are the same for audio.
> If so, we could probably get rid of the > machine_is_omap_zoom2() check, right? I think it'd better to add checks for the machines supported by the driver, so it fails nicely with unsupported ones. I'll go thru the differences between our boards and send a patch soon. > - Anand Thanks, -Misa -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
