> -----Original Message----- > From: Russell King - ARM Linux [mailto:[email protected]] > Sent: Saturday, October 09, 2010 4:53 AM > To: Menon, Nishanth > Cc: Poddar, Sourav; G, Manjunath Kondaiah; > [email protected]; Shilimkar, Santosh; > [email protected]; Varadarajan, Charulatha > Subject: Re: [PATCH v4] ARM: Fix sparse warnings due to > variables conflicts. > > On Fri, Oct 08, 2010 at 06:32:29AM -0500, Nishanth Menon wrote: > > Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following: > >> Fix the sparse warnings generated due to conflicts in > variables used in readl/writel. > >> > >> > >> drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows > an earlier one > >> drivers/net/smc91x.c:312:8: originally declared here > >> > >> With this change, about 200 sparse warnings are fixed. > > The commit message could be a little more detailed. > > see http://marc.info/?l=linux-omap&m=128648102511076&w=2 > > > > also should $subject say ARM: io: fix namespace conflict > > to better reflect the fix? sparse warnings are just an > indication IMHO
That sounds more appropriate. Thanks. > > afaics, this patch will cause checkpatch to issue warnings > due to lines > over 80 characters. Okay. The patch was not touching the coding style of how the macros were defined earlier. Anyways, would fix the warnings and send the patch asap. > > I can't check that because I don't have the original patch via the > linux-arm-kernel mailing list. > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
