Hi Rajendra,
some brief comments -
On Thu, 23 Sep 2010, Rajendra Nayak wrote:
> This is in preparation of splitting the powerdomain framework into
> platform-independent part (for all omaps) and platform-specific
> parts.
> The platform-independent code would reside in plat-omap/powerdomain.c
> and the platform-specific code will resides in
> mach-omap2/powerdomain-xxxx.c files.
Unless you are planning to add powerdomain support for OMAP1, it seems
best to keep the powerdomain code in mach-omap2/. That will also avoid
sideways includes like these:
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/plat-omap/powerdomain.c
> @@ -26,19 +26,19 @@
>
> #include <asm/atomic.h>
>
> -#include "cm.h"
> -#include "cm-regbits-34xx.h"
> -#include "cm-regbits-44xx.h"
> -#include "prm.h"
> -#include "prm-regbits-34xx.h"
> -#include "prm-regbits-44xx.h"
> +#include "../mach-omap2/cm.h"
> +#include "../mach-omap2/cm-regbits-34xx.h"
> +#include "../mach-omap2/cm-regbits-44xx.h"
> +#include "../mach-omap2/prm.h"
> +#include "../mach-omap2/prm-regbits-34xx.h"
> +#include "../mach-omap2/prm-regbits-44xx.h"
>
> #include <plat/cpu.h>
> #include <plat/powerdomain.h>
> #include <plat/clockdomain.h>
> #include <plat/prcm.h>
>
> -#include "pm.h"
> +#include "../mach-omap2/pm.h"
>
> enum {
> PWRDM_STATE_NOW = 0,
> --
> 1.7.0.4
>
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
