On Tue, Oct 19, 2010 at 1:55 AM, Tony Lindgren <[email protected]> wrote: > * Tomi Valkeinen <[email protected]> [101018 06:55]: >> On Mon, 2010-10-18 at 16:10 +0300, Tomi Valkeinen wrote: >> > Hi, >> > >> > On Fri, 2010-10-15 at 14:46 +0200, ext Felipe Contreras wrote: >> > > So that we can ioremap happily. >> > > >> > > Cc: Tomi Valkeinen <[email protected]> >> > > Signed-off-by: Felipe Contreras <[email protected]> >> > > --- >> > > drivers/video/omap2/vram.c | 2 ++ >> > > 1 files changed, 2 insertions(+), 0 deletions(-) >> > > >> > > diff --git a/drivers/video/omap2/vram.c b/drivers/video/omap2/vram.c >> > > index f6fdc20..1a99777 100644 >> > > --- a/drivers/video/omap2/vram.c >> > > +++ b/drivers/video/omap2/vram.c >> > > @@ -575,6 +575,8 @@ void __init omap_vram_reserve_sdram_memblock(void) >> > > } >> > > } else { >> > > paddr = memblock_alloc_base(size, PAGE_SIZE, >> > > MEMBLOCK_REAL_LIMIT); >> > > + memblock_free(paddr, size); >> > > + memblock_remove(paddr, size); >> > > } >> > > >> > > omap_vram_add_region(paddr, size); >> > >> > I tested this on OMAP3 SDP board, on top of my DSS2 tree. I can boot up >> > fine, but my test program crashes the kernel (dump below). >> > >> > This crash doesn't happen if I have the "HACK: OMAP: DSS2: OMAPFB: use >> > phys_to_virt for RAM mappings" patch in (I removed that during testing >> > this patch). >> > >> > I don't know yet what is crashing the kernel, but I'd guess it's the >> > fact that my test program reallocates the framebuffer memory with >> > OMAPFB_SETUP_MEM ioctl. >> >> Ah, sorry, I was missing the patch from Russel which you mentioned in >> another mail (http://article.gmane.org/gmane.linux.kernel/1047146). With >> that patch included things seem to work. > > Tomi, I assume you're queuing these? If so, for both: > > Acked-by: Tony Lindgren <[email protected]>
Note that this depends on a patch by Russell that is not clear if it will be merged on .37. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
