> -----Original Message-----
> From: [email protected] 
> [mailto:[email protected]] On Behalf Of 
> [email protected]
> Sent: Thursday, October 28, 2010 6:59 PM
> To: [email protected]
> Cc: Kridner, Jason; [email protected]; 
> [email protected]; Menon, Nishanth; 
> [email protected]; [email protected]; Srinath
> Subject: [Patch v3] OMAP: AM3517/05: Add craneboard support
> 

[snip]

> +MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")

Compared against AM3715, I see these missing:
        .phys_io        = 0x48000000,
        .io_pg_offst    = ((0xd8000000) >> 18) & 0xfffc,

Are these not required?

> +     .boot_params    = 0x80000100,
> +     .map_io         = omap3_map_io,
> +     .reserve        = omap_reserve,
              ^^^^^^^^
Check for mix of space & tabs here.

~sanjeev

> +     .init_irq       = am3517_crane_init_irq,
> +     .init_machine   = am3517_crane_init,
> +     .timer          = &omap_timer,
> +MACHINE_END
> diff --git a/arch/arm/plat-omap/include/plat/uncompress.h 
> b/arch/arm/plat-omap/include/plat/uncompress.h
> index 9036e37..229fbf2 100644
> --- a/arch/arm/plat-omap/include/plat/uncompress.h
> +++ b/arch/arm/plat-omap/include/plat/uncompress.h
> @@ -145,6 +145,7 @@ static inline void 
> __arch_decomp_setup(unsigned long arch_id)
>               /* omap3 based boards using UART3 */
>               DEBUG_LL_OMAP3(3, cm_t35);
>               DEBUG_LL_OMAP3(3, cm_t3517);
> +             DEBUG_LL_OMAP3(3, craneboard);
>               DEBUG_LL_OMAP3(3, igep0020);
>               DEBUG_LL_OMAP3(3, igep0030);
>               DEBUG_LL_OMAP3(3, nokia_rx51);
> -- 
> 1.7.1.226.g770c5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe 
> linux-omap" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to