* Kevin Hilman <[email protected]> [101116 11:45]: > Tony Lindgren <[email protected]> writes: > > > * Tomi Valkeinen <[email protected]> [101116 05:41]: > >> On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > >> > Hi, > >> > Any more comments on this patch? > >> > >> I'm not sure if enabling kernel options by default is a good thing. > >> Somehow I remember that enabling things by default is not looked kindly > >> at. Shouldn't they be enabled in the arch/arm/configs config file, if > >> they are wanted? > >> > >> Tony, do you have opinnion on this? Should DSS features be enabled by > >> default in the Kconfig files, or only in the board config file? > > > > The best thing would be to have DSS y if ARCH_OMAP2PLUS or similar, > > then have all the features built in and pass the configuration options > > in platform_data. That still allows disabling certain features with > > Kconfig if needed for memory consumption etc. But the omap2plus_defconfig > > should "just work" on all the boards. > > Personally, I'd much rather see DSS core and optional features default > to being built as a module. > > Other than a splash screen, there's no reason DSS is needed for a > minimal boot.
Sure a module would be even better. My point is that the selection of all the features should be enabled by default and the board options come from platform_data. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
