Hi Dan,
* Dan Murphy <[email protected]> [101117 09:58]:
> @@ -81,10 +81,14 @@ void omap_mux_write(struct omap_mux_partition *partition,
> u16 val,
> void omap_mux_write_array(struct omap_mux_partition *partition,
> struct omap_board_mux *board_mux)
> {
> - while (board_mux->reg_offset != OMAP_MUX_TERMINATOR) {
> - omap_mux_write(partition, board_mux->value,
> - board_mux->reg_offset);
> - board_mux++;
> + if (partition) {
> + while (board_mux->reg_offset != OMAP_MUX_TERMINATOR) {
> + omap_mux_write(partition, board_mux->value,
> + board_mux->reg_offset);
> + board_mux++;
> + }
> + } else {
> + pr_err("%s: Partition was NULL\n", __func__);
> }
> }
>
Can you please make this into a separate patch. And instead of
indenting the code more, just do something like:
if (!partition)
return -EINVAL;
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
