>>-----Original Message-----
>>From: [email protected] [mailto:linux-omap-
>>[email protected]] On Behalf Of Sripathy, Vishwanath
>>Sent: Wednesday, December 01, 2010 9:01 PM
>>To: [email protected]
>>Cc: [email protected]; [email protected]
>>Subject: RE: [PATCH v2 13/14] OMAP3: Add voltage dependency table for VDD1.
>>
>>Thara,
>>
>>> -----Original Message-----
>>> From: Gopinath, Thara
>>> Sent: Friday, October 29, 2010 9:08 PM
>>> To: [email protected]
>>> Cc: [email protected]; [email protected]; Cousson, Benoit;
>>> Sripathy, Vishwanath; Sawant, Anand; Gopinath, Thara
>>> Subject: [PATCH v2 13/14] OMAP3: Add voltage dependency table for
>>> VDD1.
>>>
>>> In OMAP3, for perfomrance reasons when VDD1 is at voltage above
>>> 1.075V, VDD2 should be at 1.15V for perfomrance reasons. This
>>> patch introduce this cross VDD dependency for OMAP3 VDD1.
>>>
>>> Signed-off-by: Thara Gopinath <[email protected]>
>>> ---
>>>  arch/arm/mach-omap2/voltage.c |   19 +++++++++++++++++++
>>>  1 files changed, 19 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-
>>> omap2/voltage.c
>>> index 6f85f75..241fac5 100644
>>> --- a/arch/arm/mach-omap2/voltage.c
>>> +++ b/arch/arm/mach-omap2/voltage.c
>>> @@ -350,6 +350,23 @@ static struct omap_volt_data
>>> omap44xx_vdd_core_volt_data[] = {
>>>     {.volt_nominal = 1100000, .sr_errminlimit = 0xF9, .vp_errgain =
>>> 0x16},
>>>  };
>>>
>>> +/* OMAP 3430 MPU Core VDD dependency table */
>>> +static struct omap_vdd_dep_volt omap34xx_vdd1_vdd2_data[] = {
>>> +   {.main_vdd_volt = 975000, .dep_vdd_volt = 1050000},
>>> +   {.main_vdd_volt = 1075000, .dep_vdd_volt = 1050000},
>>> +   {.main_vdd_volt = 1200000, .dep_vdd_volt = 1150000},
>>> +   {.main_vdd_volt = 1270000, .dep_vdd_volt = 1150000},
>>> +   {.main_vdd_volt = 1350000, .dep_vdd_volt = 1150000},
>>> +   {.main_vdd_volt = 0, .dep_vdd_volt = 0},
>>> +};
>>> +
>>> +static struct omap_vdd_dep_info omap34xx_vdd1_dep_info[] = {
>>> +   {
>>> +           .name   = "core",
>>> +           .dep_table = omap34xx_vdd1_vdd2_data,
>>> +   },
>>> +};
>>
>>Dependency table for 3630 is missing. Pls add the same.
>>Also voltage values for 3630 does not match those on OPP table. Pls align
>>them.

I think you have already given these comments on the list. Any ways I am 
incorporating them.

Regards
Thara
>>
>>Vishwa
>>> +
>>>  /* By default VPFORCEUPDATE is the chosen method of voltage scaling
>>> */
>>>  static bool voltscale_vpforceupdate = true;
>>>
>>> @@ -574,6 +591,8 @@ static void __init
>>> omap3_vdd_data_configure(struct omap_vdd_info *vdd)
>>>                     vdd->volt_data = omap34xx_vdd1_volt_data;
>>>                     vdd->volt_data_count =
>>>
>>>     ARRAY_SIZE(omap34xx_vdd1_volt_data);
>>> +                   vdd->dep_vdd_info = omap34xx_vdd1_dep_info;
>>> +                   vdd->nr_dep_vdd =
>>> ARRAY_SIZE(omap34xx_vdd1_dep_info);
>>>             }
>>>
>>>             vdd->vp_reg.tranxdone_status =
>>> OMAP3430_VP1_TRANXDONE_ST_MASK;
>>> --
>>> 1.7.0.4
>>--
>>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>the body of a message to [email protected]
>>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to