On Wed, Dec 15, 2010 at 2:28 PM, Varadarajan, Charulatha <[email protected]> wrote:
> Shubhro,
>
> On Wed, Dec 15, 2010 at 13:24, Datta, Shubhrajyoti <[email protected]>
> wrote:
>> On Wed, Dec 15, 2010 at 11:01 AM, Varadarajan, Charulatha <[email protected]>
>> wrote:
>>> * Shubhrajyoti D <[email protected]> [2010-12-15 09:39:58 +0530]:
>>>
>>>> From: Abraham Arce <[email protected]>
>>>>
>>>> Enable Runtime PM functionality in OMAP4 driver based on the following
>>>> assumptions
>>>>
>>>> A minimal pm runtime get/put approach is implemented in probe/remove calls
>>>> respectively.
>>>>
>>>> - Keyboard controller in wakeup domain so it is always on and
>>>> power impact may be minimal
>>>> - In OMAP4 the device control is at module/device level and ick/fclk level
>>>> control is
>>>> difficult so cutting of clocks will prevent interrupts.
>>>>
>>>> Signed-off-by: Abraham Arce <[email protected]>
>>>> Cc: Kevin Hilman <[email protected]>
>>>
>>> This patch is sent thrice (once with a different subject) but the
>>> version numbers are the same. It is not clear what is the intention of this
>>> patch without hwmod database update. Am I missing any more patch here?
>> Yes missed the version.
>> I have updated the change logs to be more descriptive and the subject line.
>>
>>
>> Regarding the hwmod database update. That I deffered for reasons
>> - The clock changes need to be there as the update would mean reset of
>> clocks.
>> - Thought of completing the drivers/input before the hwmod database
>> and the board changes.
>> - Also currently the driver relies on the uboot settings for clock
>> this might remove that dependency.
>
> I wish to differ here. This patch would not fix the above issues because
> pm runtime APIs (for OMAP) purely rely on omap_device and the keypad
> driver is not yet hwmod adapted. Atleast put a dependency on any
> hwmod series if you had sent them before.
OK will send a series with both patches mentioning the dependency.
>
> -V Charulatha
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
