Hi, Sorry for the delay in responding, mostly in read-only mode this week :)
* Felipe Balbi <[email protected]> [101227 09:17]: > > > >What was the problem you saw with N810 which caused the need for > >commit fc8c2f1dba400e9a0d1d82756e0e2f52dfe2f4b6, quoted below ? Heh found it after some debugging, we need to call init_completion :) > >Also, the rtc->reset_occured flag seems to be quite useless as it's > >never read, only written. Yeah looks like that can be removed. Reverted the earlier if 0 hack and pushed the following patch to the cbus branch. Regards, Tony From: Tony Lindgren <[email protected]> Date: Thu, 30 Dec 2010 12:47:00 -0800 Subject: [PATCH] cbus: Fix retu_rtc_do_reset We need to also call init_completion before using it. Signed-off-by: Tony Lindgren <[email protected]> --- a/drivers/cbus/retu-rtc.c +++ b/drivers/cbus/retu-rtc.c @@ -289,6 +289,7 @@ static int __init retu_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rtc); INIT_WORK(&rtc->work, retu_rtca_expired); mutex_init(&rtc->mutex); + init_completion(&rtc->sync); r = retu_get_status(); if (!r) { -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
