"Hiremath, Vaibhav" <[email protected]> writes: >> -----Original Message----- >> From: Varadarajan, Charulatha [mailto:[email protected]] >> Sent: Monday, January 24, 2011 8:13 PM >> To: Hiremath, Vaibhav >> Cc: [email protected]; [email protected] >> Subject: Re: [PATCH] OMAP3EVM: Add vio regulator supply required for >> ads7846 TSC driver >> >> On Mon, Jan 24, 2011 at 20:02, <[email protected]> wrote: >> > From: Vaibhav Hiremath <[email protected]> >> > >> >> Please add a patch description. >> > [Hiremath, Vaibhav] I can copy/paste subject line again here, but I thought > subject description is sufficient to explain purpose of patch so did not > mentioned anything here.
Please summarize the change in a descriptive changelog. You can do more than copy/paste and add a few more lines of description, e.g. The on-board touchscreen controller on the OMAP3EVM is powered by... The changelogs go into the *permanent* history, so changelogs should be descriptive enough not just for those familiar with the code but for those reading the changelogs in the future. Thanks, Kevin > >> > >> > Signed-off-by: Vaibhav Hiremath <[email protected]> >> > --- >> > arch/arm/mach-omap2/board-omap3evm.c | 20 ++++++++++++++++++++ >> > 1 files changed, 20 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- >> omap2/board-omap3evm.c >> > index a158d21..ed0311c 100644 >> > --- a/arch/arm/mach-omap2/board-omap3evm.c >> > +++ b/arch/arm/mach-omap2/board-omap3evm.c >> > @@ -538,6 +538,25 @@ static struct regulator_init_data omap3_evm_vpll2 = >> { >> > .consumer_supplies = &omap3_evm_vpll2_supply, >> > }; >> > >> > +/* ads7846 on SPI */ >> > +static struct regulator_consumer_supply omap3evm_vio_supply = >> > + REGULATOR_SUPPLY("vcc", "spi1.0"); >> > + >> > +/* VIO for ads7846 */ >> > +static struct regulator_init_data omap3evm_vio = { >> > + .constraints = { >> > + .min_uV = 1800000, >> > + .max_uV = 1800000, >> > + .apply_uV = true, >> > + .valid_modes_mask = REGULATOR_MODE_NORMAL >> > + | REGULATOR_MODE_STANDBY, >> > + .valid_ops_mask = REGULATOR_CHANGE_MODE >> > + | REGULATOR_CHANGE_STATUS, >> > + }, >> > + .num_consumer_supplies = 1, >> > + .consumer_supplies = &omap3evm_vio_supply, >> > +}; >> > + >> > static struct twl4030_platform_data omap3evm_twldata = { >> > .irq_base = TWL4030_IRQ_BASE, >> > .irq_end = TWL4030_IRQ_END, >> > @@ -550,6 +569,7 @@ static struct twl4030_platform_data omap3evm_twldata >> = { >> > .codec = &omap3evm_codec_data, >> > .vdac = &omap3_evm_vdac, >> > .vpll2 = &omap3_evm_vpll2, >> > + .vio = &omap3evm_vio, >> > }; >> > >> > static struct i2c_board_info __initdata omap3evm_i2c_boardinfo[] = { >> > -- >> > 1.6.2.4 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
