On Wed, Feb 2, 2011 at 1:01 AM, Tony Lindgren <[email protected]> wrote: > * Dave Martin <[email protected]> [110201 08:34]: >> On Tue, Jan 25, 2011 at 5:48 PM, <[email protected]> wrote: >> > From: Jean Pihet <[email protected]> >> > >> > Fix a potential problem with function types when calling the >> > fncpy API to copy the PM code functions to SRAM. >> > >> > Signed-off-by: Jean Pihet <[email protected]> >> > --- >> > arch/arm/plat-omap/include/plat/sram.h | 4 ++-- >> > 1 files changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/arm/plat-omap/include/plat/sram.h >> > b/arch/arm/plat-omap/include/plat/sram.h >> > index d673f2c..f500fc3 100644 >> > --- a/arch/arm/plat-omap/include/plat/sram.h >> > +++ b/arch/arm/plat-omap/include/plat/sram.h >> > @@ -18,10 +18,10 @@ extern void *omap_sram_push_address(unsigned long >> > size); >> > >> > /* Macro to push a function to the internal SRAM, using the fncpy API */ >> > #define omap_sram_push(funcp, size) ({ \ >> > - typeof(&funcp) _res = NULL; \ >> > + typeof(&(funcp)) _res = NULL; \ >> > void *_sram_address = omap_sram_push_address(size); \ >> > if (_sram_address) \ >> > - _res = fncpy(_sram_address, &funcp, size); \ >> > + _res = fncpy(_sram_address, &(funcp), size); \ >> > _res; \ >> > }) >> >> I believe this is sound, though I'm not yet in a position to test it fully. >> >> When I have the OMAP kernel building with Thumb-2 again I will follow up. >> >> Cheers >> ---Dave >> >> >> Reviewed-by: Dave Martin <[email protected]> > > Looks good to me too: > > Acked-by: Tony Lindgren <[email protected]> Ok thanks!
> > I'll add this to omap-testing branch, but as Russell has this queued, > you'll have to send this to him on linux-arm-kernel list. I have folded the 2 original patches code and acks into '[PATCH] omap: use fncpy to copy the PM code functions to SRAM' and re-sent to l-a-k and l-o MLs. Also submitted to Russell's patch system. > > Regards, > > Tony > Regards, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
