On Sat, Feb 5, 2011 at 3:46 AM, Kevin Hilman <[email protected]> wrote: > "Cousson, Benoit" <[email protected]> writes: > >> On 2/4/2011 8:45 PM, Hilman, Kevin wrote: >>> Kishon Vijay Abraham I<[email protected]> writes: >>> >>>> Adds a structure member 'name' to 'omap_hwmod_addr_space' structure. >>>> The drivers can use platform_get_resource_byname() to get resource of >>>> type 'IORESOURCE_MEM' by name so that it need not rely on the order to get >>>> the proper resource. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I<[email protected]> >>>> Signed-off-by: Benoit Cousson<[email protected]> >>>> --- >>>> arch/arm/mach-omap2/omap_hwmod.c | 1 + >>>> arch/arm/plat-omap/include/plat/omap_hwmod.h | 4 +++- >>>> 2 files changed, 4 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/omap_hwmod.c >>>> b/arch/arm/mach-omap2/omap_hwmod.c >>>> index 709543a..7bd4900 100644 >>>> --- a/arch/arm/mach-omap2/omap_hwmod.c >>>> +++ b/arch/arm/mach-omap2/omap_hwmod.c >>>> @@ -1898,6 +1898,7 @@ int omap_hwmod_fill_resources(struct omap_hwmod *oh, >>>> struct resource *res) >>>> os = oh->slaves[i]; >>>> >>>> for (j = 0; j< os->addr_cnt; j++) { >>>> + (res + r)->name = (os->addr + j)->name; >>>> (res + r)->start = (os->addr + j)->pa_start; >>>> (res + r)->end = (os->addr + j)->pa_end; >>>> (res + r)->flags = IORESOURCE_MEM; >>>> diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h >>>> b/arch/arm/plat-omap/include/plat/omap_hwmod.h >>>> index 76f0274..85899a7 100644 >>>> --- a/arch/arm/plat-omap/include/plat/omap_hwmod.h >>>> +++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h >>>> @@ -178,7 +178,8 @@ struct omap_hwmod_omap2_firewall { >>>> #define ADDR_TYPE_RT (1<< 1) >>>> >>>> /** >>>> - * struct omap_hwmod_addr_space - MPU address space handled by the hwmod >>>> + * struct omap_hwmod_addr_space - address space handled by the hwmod >>> >>> Any reason you modified the comment here? >> >> The idea of that patch is to allow hwmod to provide address space >> accessible from SDMA (though L3). Hence the suppression of the MPU. >> In the future, we might even be able to provide the address for the >> DSP or the IPU viewpoint >> > > OK, this rationale is missing from the changelog, and seems very much > unrelated to $SUBJECT patch.
ok. Will change it in the next version. > > Kevin > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
