"Premi, Sanjeev" <[email protected]> writes: >> >> This patch adds support for speed enhanced variant of OMAP35x >> processors. These parts allow ARM and IVA running at 720MHz >> and 520MHz respectively. >> >> These parts can be detected at runtime by reading contents of >> PRODID.SKUID[3:0] at 0x4830A20C [1]. >> >> This patch specifically does following: >> * Add new OPP to omap34xx_opp_def_list[] - disabled by default. >> * Detect devices capable of running at new OPP. >> * Enable new OPP only if device supports it. >> * Check for presence of IVA before attempting to enable the >> corresponding OPP. >> >> [1] http://focus.ti.com/lit/ug/spruff1d/spruff1d.pdf >> >> It appears from discussions (on this patch) that a variant of >> OMAP3430 supports this OPP but lacks runtime detection. This >> OPP can be enabled for these device by either: >> 1) Setting the bit corresponding to OMAP3_HAS_720MHZ >> in 'omap3_features'. (Refer changes to id.c) >> 2) Removing check for omap3_has_720mhz() before enabling >> the OPP. (Refer changes to opp3xxx_data.c) >> 3) Calling opp_enable() for 720MHz/VDD1 and 520MHz/VDD2 in >> the board file. (Refer changes to opp3xxx_data.c). >> This should, ideally, be done before omap3_opp_init() is >> called during device_initcall(). >> >> CAUTION: This should be done for identified parts only. >> Else, the device could be damaged permanently. >> >> Signed-off-by: Sanjeev Premi <[email protected]> >> Reviewed-by: G, Manjunath Kondaiah <[email protected]> >> --- >> >> Since v4: >> Updated the commit text addressing comments from >> Kevin Hilman ([email protected]). >> > > Kevin, > > Wanted to check if the decription addresses your comments. >
Yes, very nice. Thanks. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
