hi,

On Thu, Feb 17, 2011 at 03:15:10PM +0200, Felipe Balbi wrote:
> I can update the commit log, but basically it's the counterpart of
> musb_start(). See that we call:
> 
> if (!is_otg_enabled(musb))
>       musb_start(musb);
> 
> so we need to undo that on the error path.

Better ?

usb: musb: gadget: beautify 
usb_gadget_probe_driver()/usb_gadget_unregister_driver

Just a few cosmetic fixes to usb_gadget_probe_driver()
and usb_gadget_unregister_driver().

Decreased a few indentation levels with goto statements.

While at that, also add the missing call to musb_stop().
If we don't have OTG, there's no point of leaving
MUSB prepared for operation if a gadget driver fails
to probe. The same is valid for usb_gadget_unregister_driver(),
since we are removing the gadget driver and we don't have
OTG, we can completely unconfigure MUSB.

Signed-off-by: Felipe Balbi <[email protected]>


-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to