On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando <[email protected]> wrote: > On Wed, Feb 16, 2011 at 1:35 PM, David Cohen <[email protected]> wrote: >> Add support to register an isr for IOMMU fault situations and adapt it >> to allow such (*isr)() to be used as fault callback. Drivers using IOMMU >> module might want to be informed when errors happen in order to debug it >> or react. >> >> Signed-off-by: David Cohen <[email protected]> >> --- >> arch/arm/mach-omap2/iommu2.c | 17 +++++++++- >> arch/arm/plat-omap/include/plat/iommu.h | 14 ++++++++- >> arch/arm/plat-omap/iommu.c | 52 >> ++++++++++++++++++++++--------- >> 3 files changed, 65 insertions(+), 18 deletions(-) >> > .... > >> @@ -917,6 +912,33 @@ void iommu_put(struct iommu *obj) >> } >> EXPORT_SYMBOL_GPL(iommu_put); >> >> +int iommu_set_isr(const char *name, >> + int (*isr)(struct iommu *obj, u32 da, u32 iommu_errs, >> + void *priv), >> + void *isr_priv) >> +{ >> + struct device *dev; >> + struct iommu *obj; >> + > > if the driver support multiple user for the same iommu why can only > one callback be registered? should it support register multiple > callback function (one per user)?
Can you define a scenario for that? On OMAP3 ISP the multiple users are the multiple ISP submodule, but I don't think it's necessary all submodule to have a specific callback. ISP core layer should handle. Br, David > > Regards, > Fernando. > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
